replaces build bool with buttons #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return false | ||
|
|
||
| func _parse_property(object, type, name, hint_type, hint_string, usage_flags, wide): | ||
| return false |
There was a problem hiding this comment.
Accidental early return?
There was a problem hiding this comment.
yeah, I was testing something and I guess it got left in
greenfox1505
force-pushed
the
build-button
branch
from
d6927ce to
9fb8fde
Compare
|
Fixed |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing! Help us understand your pull request by explaining:
What it changes
This replaces the bool build button with a button to trigger builds.
Why it's needed
Just makes it clearer what it does from the inspector
This will not be necessary after 4.3, if/when iFire's
@tool_buttongets merged.